This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Fix endless forum login (#659) #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for checking if the user is already logged in has been updated to look for the absence of a specific span class within the page text. Previously, the check was only for the presence of a "You are already logged in" message. Login from a different region generates another login message and would have failed login.
Adjusted the loop control flow to break out of the login attempt loop immediately once we detect that we are not already logged in, streamlining the process and potentially reducing the number of unnecessary login attempts.