This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Add dates to history #884
Merged
Add dates to history #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `created_at` and `completed_at` columns to the DB. This is useful for several possible future uses. # Uses There are several uses for this info, but the one that comes up pretty often is when bad files are downloaded during an outage before cyberdrop-dl knows about the new Etag (such as when Bunkr creates a new maintenance video). If you know when the issue was occurring, this could help you find which files might be bad and need to be redownloaded. Knowing when the item was added to the DB can be used to prioritize downloads that are more recently added and therefore more likely to succeed first. Items that have been incomplete for a long time will most likely never finish, so trying them first just burns through your rate limit. # Details | Column | Description |:--------|:------------- | `created_at` | When the item was added to the DB | `completed_at` | When the item was marked completed The columns are obviously unset for items that predate these additions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is something you're interested in, but I figured I'd toss it your way in case you were. I added this in my fork so that I could find the recently downloaded files without having to recrawl the filesystem every time.
This adds
created_atandcompleted_atcolumns to the DB.Uses
This is useful for several possible future uses. For example:
Finding files for cleanup
Bad files are sometimes downloaded during an outage. Such as when Bunker creates a new maintenance video before cyberdrop-dl knows the new path or Etag. If you know when the issue was occurring, this allows one to find which files might be bad and need to be redownloaded.
Prioritizing recently added items
Items that have been incomplete for a long time will most likely never finish, so trying them first just burns through your rate limit. If the more recently added items are tried first they are more likely to succeed before the rate limit is hit.
Details
created_atcompleted_atThe columns are obviously unset for items that predate these additions.