Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cmd(::Vector{String}) to make curl Cmd #1

Conversation

david-macmahon
Copy link
Contributor

This avoids having to quote strings that may contain embedded spaces (e.g. the query string), which can cause problems on some systems if those surrending quotes are not removed from the query.

This avoids having to quote strings that may contain embedded spaces
(e.g. the query string), which can cause problems on some systems if
those surrending quotes are not removed from the query.
@david-macmahon
Copy link
Contributor Author

Not sure about this PR. I think the quoting conventions (requirements?) of different curl versions may have the potential to be problematic either with or without the quotes. With the quotes is problematic for at least one curl version (7.47.0), but not problematic for 7.61.1. Without the quotes works for simple queries on both of those curl versions, but not sure it will work with more complex queries that happen to contain "curl-special" characters (e.g. quotes and semicolons). I think switching to HTTP.jl is the way to go. I'll probably open a different PR for the HTTP.jl solution and close this one at that time.

@david-macmahon
Copy link
Contributor Author

Closing this PR because #2 fixes the same issue in a better (IMHO) way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant