Fixes for v0.5 #228
Fixes for v0.5 #228
Conversation
| @@ -19,13 +19,13 @@ vertex_index(v::KeyVertex) = v.index | |||
|
|
|||
| type ExVertex | |||
| index::Int | |||
| label::UTF8String | |||
| label::String | |||
There was a problem hiding this comment.
Maybe Compat.UTF8String in fields of types if we still want them to be a concrete types.
There was a problem hiding this comment.
Yes. Otherwise this changes the API and performance on 0.4.
Current coverage is 85.65% (diff: 85.71%)@@ master #228 diff @@
==========================================
Files 24 24
Lines 1435 1443 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1230 1236 +6
- Misses 205 207 +2
Partials 0 0
|
| @@ -63,15 +63,15 @@ function to_dot(attrs::AttributeDict) | |||
| if isempty(attrs) | |||
| "" | |||
| else | |||
| string("[",join(map(a -> to_dot(a[1], a[2]), attrs),","),"]") | |||
| string("[",join(map(a -> to_dot(a[1], a[2]), [attrs...]),","),"]") | |||
There was a problem hiding this comment.
would collect work for this?
There was a problem hiding this comment.
collect(attrs) instead of [attrs...] works too.
| @@ -3,8 +3,8 @@ os: | |||
| - linux | |||
| - osx | |||
| julia: | |||
| - 0.3 | |||
There was a problem hiding this comment.
don't delete this unless you also change the minimum julia version in REQUIRE
|
Thanks @ranjanan |
| @@ -179,7 +179,7 @@ edge_property{T,V}(visitor::VectorEdgePropertyInspector{T}, e, g::AbstractGraph{ | |||
| edge_property_requirement{T, V}(visitor::AbstractEdgePropertyInspector{T}, g::AbstractGraph{V}) = @graph_requires g edge_map | |||
|
|
|||
| type AttributeEdgePropertyInspector{T} <: AbstractEdgePropertyInspector{T} | |||
| attribute::UTF8String | |||
| attribute::String | |||
|
@tkelman Should we move Graphs.jl to a new org and then tag a new release? |
|
which org? JuliaArchive or something else? |
|
JuliaArchive sounds good. |
|
Should we also rename it to LegacyGraphs in the process? |
|
Renaming basically means re-registering a new copy from scratch. As described in #227 (comment), it's not worth doing that unless we do a merge commit and replace the content with something new. |
|
Ok, let's just move it. |
|
Moved, but we should document the fact that this isn't actively maintained. #227 (comment) |
|
Can you add a note to the README? |
|
Although isn't being in JuliaArchives enough of a signal? |
|
JuliaArchive doesn't have any description of what it means for a package to be here. You also only briefly see what user/organization a package comes from when you do |
|
Is README enough? @ranjanan Can you also register the new version in METADATA? |
|
Remember to do |
|
Sure, will tag a new version once #229 is merged. |
|
Tagged. (JuliaLang/METADATA.jl#6148) |
This attempts to fix Graphs.jl for v0.5