Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on GitHub Actions #46

Closed
juliohm opened this issue Jul 25, 2022 · 15 comments · Fixed by #47
Closed

Fix build on GitHub Actions #46

juliohm opened this issue Jul 25, 2022 · 15 comments · Fixed by #47

Comments

@juliohm
Copy link
Member

juliohm commented Jul 25, 2022

Hi @LakshyaKhatri, hope you are doing well.

In an attempt to port the Travis build to GitHub Actions I realized too late that you had added custom instructions in Travis to authenticate remotely with CDSAPI:

before_install:
- openssl aes-256-cbc -K $encrypted_fbf94d2678c4_key -iv $encrypted_fbf94d2678c4_iv
  -in .cdsapirc.enc -out $HOME\/.cdsapirc -d

Could you please help adding these instructions to our new CI.yml workflow? I also accidentally deleted the .cdsapirc.enc file you added to the repository. Please feel free to revive it if necessary.

@LakshyaKhatri
Copy link
Member

Hey! Hi @juliohm ! Sorry for a late response. Sure, I'll take a look at it on my end

@juliohm
Copy link
Member Author

juliohm commented Jul 28, 2022

Thank you @LakshyaKhatri ! Appreciate it! Looking forward to the fix ❤️

@LakshyaKhatri
Copy link
Member

Hi @juliohm, I will need a little help on this. I was thinking to change the auth process this way:

  1. Add the auth instructions to github environment variables
  2. Now, before running the test suite we can create a .cdsapirc file on the fly using the details in the environment variables (and delete it in a finalization process).

That way we will not be maintaining a .cdsapirc.enc file on our repository. 😸💡
Or we can do it the old way i.e. add an encrypted version of .cdsapirc in our repo and decrypt it in the CI.

What do you suggest?

@LakshyaKhatri
Copy link
Member

Ah! nvm, I just learned we have to store env variable values in the CI file itself 😶‍🌫️

@juliohm
Copy link
Member Author

juliohm commented Jul 31, 2022 via email

@juliohm
Copy link
Member Author

juliohm commented Jul 31, 2022

The build is failing on Windows now because GRIB.jl does not support the platform.

@juliohm
Copy link
Member Author

juliohm commented Jul 31, 2022

Opened an issue there: weech/GRIB.jl#14

@LakshyaKhatri
Copy link
Member

LakshyaKhatri commented Aug 1, 2022

Wondering if I should propose a PR to GRIB.jl. I'll try my hands on it once 🤞🏽

@juliohm
Copy link
Member Author

juliohm commented Aug 1, 2022

If you have the time and knowledge to fix it, please feel free to contribute a fix ❤️

@juliohm
Copy link
Member Author

juliohm commented Dec 18, 2022

@LakshyaKhatri did you have a chance to take a look into this?

@LakshyaKhatri
Copy link
Member

LakshyaKhatri commented Dec 21, 2022

Hi @juliohm, 👋🏽

I was still waiting for a response on GRIB.jl from the maintainer. But I will take GRIB.jl issue and work on it (after the vacation season though 🙂)

@maxstb
Copy link
Contributor

maxstb commented Jan 7, 2025

In order to fix this, we first need to update the secrets for Actions (CDSAPI_URL and CDSAPI_KEY)
@juliohm Are you able to do this?

@juliohm
Copy link
Member Author

juliohm commented Jan 7, 2025

In order to fix this, we first need to update the secrets for Actions (CDSAPI_URL and CDSAPI_KEY)
@juliohm Are you able to do this?

Will take a look at it by the end of the day. Thanks for checking it.

@juliohm
Copy link
Member Author

juliohm commented Jan 8, 2025

@maxstb I've updated the secrets for Actions. Could you please check what else is necessary for the CI build?

@juliohm
Copy link
Member Author

juliohm commented Jan 8, 2025

Fixed on master

@juliohm juliohm closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants