-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CDS retreival to new API #52
Conversation
Since the API of the copernicus project was migrated, we need to update the julia package to the new API Version. |
5904b1f
to
59f0f51
Compare
Thank you @maxstb, could you please confirm the error messages don't occur in your local setup with a API key? |
I fixed tiny issues in the tests, but I cannot make them fully work locally. For the retrieve.jl test file, the second and third testsets are failing due to an unknown dataset and I cannot identify which were originally used. This might be due to the split into CDS and ADS datasets, but I am a bit lost there. Regarding the pipelines authentication, I guess that a new account needs to be created with a new Authentication token. All old accounts do not work anymore, to my best knowledge. This could be another issue. |
Is the old API still available? Or is it fully deprecated? If it is deprecated, we can proceed here and make the necessary changes to get up to date. If it is not deprecated, we need to add a |
In this documentation (https://confluence.ecmwf.int/display/CKB/Please+read%3A+CDS+and+ADS+migrating+to+new+infrastructure%3A+Common+Data+Store+%28CDS%29+Engine) it's stated, that the old infrastructure is no longer accessible |
Thank you for checking it. I will try to run the code locally by the end of the day with a new key. |
@maxstb I managed to download data with a new CDS key 💯 Do you mind updating the tests here to consider new small datasets in the new API? After you confirm the tests are ready, I can pull in the changes, test locally and merge. |
Thank you! |
Thank you @maxstb ! The last dataset is still failing for me. Could you please pull the latest changes and test locally again? |
It's also working with your latest changes. |
Can you provide me the error output? |
The issue is in the |
tar: This does not look like a tar archive |
I had some problems using the Tar package, that's why I tried using the "run" command, but I will try doing it again later on. 👍 |
We could also remove this dataset from the test suite. The API is being tested with 3 datasets already. Should we simply do that? |
Sounds fine to me. I removed the test. |
No description provided.