Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to show plots within Jupyter notebook in VSCode instead of browser #37

Closed
wants to merge 5 commits into from
Closed

update to show plots within Jupyter notebook in VSCode instead of browser #37

wants to merge 5 commits into from

Conversation

Titas22
Copy link
Contributor

@Titas22 Titas22 commented Nov 23, 2023

resolves #34

  • added auto!() container case for Jupyter running in VSCode to use IFrame without scrolling
  • updated display function to show different output in this case

…wser

added `auto!()` container case for Jupyter running in VSCode to use iFrame without scrolling, and updated display function to show different output in this case
src/PlotlyLight.jl Outdated Show resolved Hide resolved
@Titas22
Copy link
Contributor Author

Titas22 commented Jan 6, 2024

Hi @joshday, are you happy with the updated solution?

@joshday
Copy link
Member

joshday commented Jan 24, 2024

Sorry for my radio silence here! I'm happy with your solution, with the caveats:

  1. There's been a breaking change in Cobweb which will change a few display/show things here.
  2. Recently I've been working on a PlotlyLight rewrite of sorts (https://github.com/joshday/PlotlyX.jl) that attempts to fix/simplify some of the display issues. This will be the second rewrite of sorts in so many months, but it really is tricky getting the display stuff right in all environments. I think I'm on the right track this time.

@joshday
Copy link
Member

joshday commented Feb 5, 2024

Check out master or the new latest release! It should eliminate the need for this PR since the display system is improved from before.

@joshday joshday closed this Feb 5, 2024
@Titas22 Titas22 deleted the Titas22-fix-VSCodeJupyter branch February 8, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots in VSCode Jupyter notebook opens in browser instead of below cell
2 participants