Merge pull request #11 from JuliaComputing/sp/defaultheight

better default height
JuliaComputing · Feb 27, 2019 · 1ad7739 · 1ad7739
2 parents 37075d3 + 0ab6fa5
commit 1ad7739
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/TableView.jl b/src/TableView.jl
@@ -18,13 +18,21 @@ end
 to_css_size(s::AbstractString) = s
 to_css_size(s::Real) = "$(s)px"
 
-function showtable(table; dark = false, height = 500, width = "100%")
+function showtable(table; dark = false, height = :auto, width = "100%")
     if !Tables.istable(typeof(table))
         throw(ArgumentError("Argument is not a table."))
     end
 
     tablelength = Base.IteratorSize(table) == Base.HasLength() ? length(Tables.rows(table)) : nothing
 
+    if height === :auto
+        height = 500
+        if tablelength !== nothing
+            # header + footer height ≈ 40px, 28px per row
+            height = min(40 + tablelength*28, height)
+        end
+    end
+
     rows = Tables.rows(table)
     schema = Tables.schema(table)
     if schema === nothing