Skip to content

Commit

Permalink
Merge pull request #13 from JuliaComputing/sp/fixversion
Browse files Browse the repository at this point in the history
use fixed ag-grid version
  • Loading branch information
pfitzseb authored Feb 27, 2019
2 parents 63af68d + 3410a2a commit e528dfc
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 12 deletions.
1 change: 1 addition & 0 deletions ag-grid.version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20.1.0
2 changes: 1 addition & 1 deletion deps/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ag-grid
ag-grid*
build.log
20 changes: 11 additions & 9 deletions deps/build.jl
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
isdir(joinpath(@__DIR__, "ag-grid")) || mkdir(joinpath(@__DIR__, "ag-grid"))
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))

ag_grid_base = joinpath(@__DIR__, "ag-grid", "ag-grid.js")
isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community/dist/ag-grid-community.min.noStyle.js", ag_grid_base)
isdir(joinpath(@__DIR__, "ag-grid-$(version)")) || mkdir(joinpath(@__DIR__, "ag-grid-$(version)"))

ag_grid_base_style = joinpath(@__DIR__, "ag-grid", "ag-grid.css")
isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-grid.css", ag_grid_base_style)
ag_grid_base = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.js")
isfile(ag_grid_base) || download("https://unpkg.com/ag-grid-community@$(version)/dist/ag-grid-community.min.noStyle.js", ag_grid_base)

ag_grid_light = joinpath(@__DIR__, "ag-grid", "ag-grid-light.css")
isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham.css", ag_grid_light)
ag_grid_base_style = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid.css")
isfile(ag_grid_base_style) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-grid.css", ag_grid_base_style)

ag_grid_dark = joinpath(@__DIR__, "ag-grid", "ag-grid-dark.css")
isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)
ag_grid_light = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-light.css")
isfile(ag_grid_light) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham.css", ag_grid_light)

ag_grid_dark = joinpath(@__DIR__, "ag-grid-$(version)", "ag-grid-dark.css")
isfile(ag_grid_dark) || download("https://unpkg.com/ag-grid-community@$(version)/dist/styles/ag-theme-balham-dark.css", ag_grid_dark)
3 changes: 2 additions & 1 deletion src/TableView.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ export showtable
const ag_grid_imports = []

function __init__()
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))
empty!(ag_grid_imports)
for f in ["ag-grid.js", "ag-grid.css", "ag-grid-light.css", "ag-grid-dark.css"]
push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid", f)))
push!(ag_grid_imports, normpath(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", f)))
end
end

Expand Down
4 changes: 3 additions & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
using TableView
using Test, WebIO

@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid", "ag-grid.js"))
version = readchomp(joinpath(@__DIR__, "..", "ag-grid.version"))

@test isfile(joinpath(@__DIR__, "..", "deps", "ag-grid-$(version)", "ag-grid.js"))

nttable = [
(a = 2.0, b = 3),
Expand Down

0 comments on commit e528dfc

Please sign in to comment.