map(f,::DNDSparse) fix for changing value type #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shashi
reviewed
Aug 11, 2020
src/ndsparse.jl
Outdated
| @@ -483,10 +483,11 @@ internally by many DNDSparse operations. | |||
| """ | |||
| function mapchunks(f, t::DNDSparse{K,V}; keeplengths=true) where {K,V} | |||
There was a problem hiding this comment.
nice we should probably remove the V from here.
There was a problem hiding this comment.
Agreed, I changed the PR accordingly.
gkappler
force-pushed
the
mapchunks
branch
2 times, most recently
from
8cb9d34 to
d67cd0a
Compare
fixes failing cases like filter(isodd, map(v->v.a+1,ndsparse((numid=1:10,), (a=1:10,b=1:10); chunks=2)))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes failing