Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable ForwardDiff tag checking with custom backend tags #631

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Nov 20, 2024

Fixes #630

DI extensions

  • ForwardDiff: when a custom tag is provided in the backend, disable tag checking by passing Val(false) after the operator config.

DI tests

  • Test on AutoForwardDiff(; tag=ForwardDiff.Tag(...)) because if the tag doesn't subtype ForwardDiff.Tag then checktag is trivial

@gdalle gdalle merged commit 2743e18 into main Nov 20, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForwardDiff Tag from prepare_jacobian not being applied to function in jacobian!
1 participant