Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chunking #268

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Fix Chunking #268

merged 3 commits into from
Oct 28, 2023

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Oct 28, 2023

  • Add tests
  • Add downstream testing

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b4b816b) 87.35% compared to head (e4581ec) 87.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   87.35%   87.34%   -0.01%     
==========================================
  Files          21       21              
  Lines        1234     1241       +7     
==========================================
+ Hits         1078     1084       +6     
- Misses        156      157       +1     
Files Coverage Δ
src/highlevel/coloring.jl 100.00% <100.00%> (ø)
src/highlevel/finite_diff.jl 100.00% <100.00%> (ø)
src/highlevel/forward_mode.jl 100.00% <100.00%> (ø)
src/highlevel/reverse_mode.jl 100.00% <ø> (ø)
src/highlevel/common.jl 81.81% <83.33%> (+0.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title [WIP] Fix Chunking Fix Chunking Oct 28, 2023
@ChrisRackauckas
Copy link
Member

[OOP] [Immutable AD]: Error During Test at /home/runner/work/SparseDiffTools.jl/SparseDiffTools.jl/downstream/test/basictests.jl:482
 Unexpected Pass
 Expression: abs.(ForwardDiff.derivative((p->begin
                    (benchmark_nlsolve_oop(quadratic_f, #= /home/runner/work/SparseDiffTools.jl/SparseDiffTools.jl/downstream/test/basictests.jl:483 =# @SVector([1.0, 1.0]), p)).u[end]
                end), p)) ≈ 1 / (2 * sqrt(p))
 Got correct result, please change to @test if no longer broken.

That sounds good.

@ChrisRackauckas ChrisRackauckas merged commit ae88c9b into JuliaDiff:master Oct 28, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants