Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid mutation on user x #280

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Avoid mutation on user x #280

merged 1 commit into from
Dec 29, 2023

Conversation

ChrisRackauckas
Copy link
Member

Fixes #265

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (dc28eb2) 85.93% compared to head (54ce5d5) 41.77%.

Files Patch % Lines
src/differentiation/jaches_products.jl 0.00% 17 Missing ⚠️
src/differentiation/vecjac_products.jl 0.00% 9 Missing ⚠️
ext/SparseDiffToolsZygoteExt.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
- Coverage   85.93%   41.77%   -44.16%     
===========================================
  Files          22       22               
  Lines        1358     1338       -20     
===========================================
- Hits         1167      559      -608     
- Misses        191      779      +588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 61930e3 into master Dec 29, 2023
12 of 19 checks passed
@ChrisRackauckas ChrisRackauckas deleted the nomutation branch December 29, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating point arithmetic 101 - it doesn't add up! aka Don't touch user input without telling them the rules
1 participant