Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use custom tags #290

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Don't use custom tags #290

merged 2 commits into from
Apr 18, 2024

Conversation

avik-pal
Copy link
Contributor

I don't remember why we used them in the first place, but it causes tag ordering issues for higher order AD.

@avik-pal avik-pal mentioned this pull request Apr 16, 2024
Merged
@avik-pal
Copy link
Contributor Author

cc @ChrisRackauckas

@avik-pal
Copy link
Contributor Author

@ChrisRackauckas you need to merge.

@ChrisRackauckas ChrisRackauckas merged commit d5e3e49 into JuliaDiff:master Apr 18, 2024
15 of 16 checks passed
@avik-pal avik-pal deleted the ap/untag branch April 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avik-pal @ChrisRackauckas