Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest CUDA, use NCCL_jll #47

Merged
merged 17 commits into from
Jan 3, 2024
Merged

Conversation

simonbyrne
Copy link
Contributor

@simonbyrne simonbyrne commented Dec 17, 2023

This updates NCCL.jl to CUDA.jl 5, and to use the new NCCL_jll build.

@simonbyrne simonbyrne marked this pull request as ready for review December 23, 2023 00:11
@simonbyrne
Copy link
Contributor Author

simonbyrne commented Dec 23, 2023

Okay, this is now working locally for me: I've tried to keep the argument names/keywords args somewhat consistent with MPI.jl.

Remaining items

@simonbyrne
Copy link
Contributor Author

@maleadt ?

@maleadt
Copy link
Member

maleadt commented Jan 2, 2024

We don't have enough GPUs to take 3 devices and assign them to a single worker, only for testing of NCCL.jl...

@simonbyrne
Copy link
Contributor Author

Fair enough. Okay, I think this is ready. It may need a DOCUMENTER_KEY if it doesn't already exist.

@ToucheSir
Copy link

FWIW I've had no issue using libraries which use NCCL on systems with only two devices. Maybe a local environment or config issue?

@maleadt
Copy link
Member

maleadt commented Jan 3, 2024

I'll try setting up a 2 GPU worker.

@maleadt maleadt self-assigned this Jan 3, 2024
@maleadt maleadt force-pushed the sb/update branch 2 times, most recently from 61fe157 to 1065ecb Compare January 3, 2024 16:06
Not sure why; I thought this was fixed...
@maleadt maleadt merged commit e959ce5 into JuliaGPU:master Jan 3, 2024
2 checks passed
@simonbyrne simonbyrne deleted the sb/update branch January 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants