better error message for non-regognized time units

JuliaGeo · Dec 7, 2023 · 694e353 · 694e353
1 parent e071e97
commit 694e353
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/cfvariable.jl b/src/cfvariable.jl
@@ -133,7 +133,15 @@ function cfvariable(ds,
             time_origin,time_factor = CFTime.timeunits(units, calendar)
         catch err
             calendar = nothing
-            @warn(sprint(showerror,err))
+            @debug "time units parsing failed " err units calendar
+
+            message = (
+                "cannot parse time units `$units`",
+                (isnothing(calendar) ? "" : "  (calendar `$calendar`)"),
+                ": ",
+                sprint(showerror,err))
+
+            @warn(join(message))
         end
     end
 

diff --git a/test/test_scaling.jl b/test/test_scaling.jl
@@ -160,4 +160,6 @@ show(io,md.dim)
 str = String(take!(io))
 @test occursin("lon",str)
 
-#close(md)
+@test_logs (:warn, r".*analysis.*")    CDM.defVar(md,"data2",eltype(data),("lon","lat"), attrib = OrderedDict{String,Any}(    "units" => "days since analysis"));
+
+close(md)