Skip to content

Commit

Permalink
Update messages.jl
Browse files Browse the repository at this point in the history
  • Loading branch information
tcarion authored Feb 23, 2024
1 parent 8f5607c commit 09791a5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/messages.jl
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ end
from_grib_step(message::GRIB.Message, step_key::String="endStep", step_unit_key::String="stepUnits")
Returns the `step_key` value in hours.
"""
function from_grib_step(message::GRIB.Message, step_key::String="endStep", step_unit_key::String="stepUnits")::Float64
function from_grib_step(message::GRIB.Message, step_key::AbstractString="endStep", step_unit_key::AbstractString="stepUnits")::Float64

Check warning on line 61 in src/messages.jl

View check run for this annotation

Codecov / codecov/patch

src/messages.jl#L61

Added line #L61 was not covered by tests
to_seconds = GRIB_STEP_UNITS_TO_SECONDS[message[step_unit_key] + 1]
return message[step_key] * to_seconds / 3600.0
end
Expand All @@ -72,7 +72,7 @@ end
Returns the integer seconds from the epoch to the verifying month value in the
GRIB message.
"""
function from_grib_month(message::GRIB.Message, verifying_month_key::String="verifyingMonth", epoch::DateTime=DEFAULT_EPOCH)::Union{Int,Missing}
function from_grib_month(message::GRIB.Message, verifying_month_key::AbstractString="verifyingMonth", epoch::DateTime=DEFAULT_EPOCH)::Union{Int,Missing}
if !haskey(message, verifying_month_key)
return missing
end
Expand All @@ -96,7 +96,7 @@ julia> GDS.build_valid_time(10, 10)
((), 36010)
```
"""
function build_valid_time(time::Int, step::Int)::Tuple{Tuple{},Int64}
function build_valid_time(time::Integer, step::Integer)::Tuple{Tuple{},Int64}

Check warning on line 99 in src/messages.jl

View check run for this annotation

Codecov / codecov/patch

src/messages.jl#L99

Added line #L99 was not covered by tests
step_s = step * 3600

data = time + step_s
Expand All @@ -111,7 +111,7 @@ julia> GDS.build_valid_time([10], 10)
(("time",), [36010])
```
"""
function build_valid_time(time::Array{Int,1}, step::Int)::Tuple{Tuple{String},Array{Int64,1}}
function build_valid_time(time::Array{Integer,1}, step::Integer)::Tuple{Tuple{String},Array{Int64,1}}

Check warning on line 114 in src/messages.jl

View check run for this annotation

Codecov / codecov/patch

src/messages.jl#L114

Added line #L114 was not covered by tests
step_s = step * 3600

data = time .+ step_s
Expand All @@ -126,7 +126,7 @@ julia> GDS.build_valid_time(1, [10])
(("step",), [36001])
```
"""
function build_valid_time(time::Int, step::Array{Int,1})::Tuple{Tuple{String},Array{Int64,1}}
function build_valid_time(time::Integer, step::Array{Integer,1})::Tuple{Tuple{String},Array{Int64,1}}

Check warning on line 129 in src/messages.jl

View check run for this annotation

Codecov / codecov/patch

src/messages.jl#L129

Added line #L129 was not covered by tests
step_s = step * 3600

data = time .+ step_s
Expand All @@ -146,7 +146,7 @@ julia> GDS.build_valid_time([10], [10])
((), 36010)
```
"""
function build_valid_time(time::Array{Int,1}, step::Array{Int,1})
function build_valid_time(time::Array{Integer,1}, step::Array{Integer,1})

Check warning on line 149 in src/messages.jl

View check run for this annotation

Codecov / codecov/patch

src/messages.jl#L149

Added line #L149 was not covered by tests
step_s = step * 3600

if length(time) == 1 && length(step) == 1
Expand Down Expand Up @@ -215,7 +215,7 @@ Read a specific key from a GRIB.jl message. Attempts to convert the raw value
associated with that key using the [`COMPUTED_KEYS`](@ref COMPUTED_KEYS) mapping
to `from_grib_*` functions.
"""
function read_message(message::GRIB.Message, key::String)
function read_message(message::GRIB.Message, key::AbstractString)
value = missing

if key in keys(COMPUTED_KEYS)
Expand Down

0 comments on commit 09791a5

Please sign in to comment.