Update conversion from GRIB to NetCDF example #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call
NCDatasets.write(netcdf_file,GRIBDataset(grib_file))
does not dispatch on any type defined in NCDatasets and the functionwrite
is a generic function from julia Base. Currently, NCDatasets is the only module which defines a functionwrite(dest_filename::AbstractString, src::CommonDataModel.AbstractDataset)
. I am wondering if it is not better to change this example with the netcdf dataset as the first argument towrite
.For your information, I am working on ZarrDatasets.jl (still unregistered) and the GRIB to Zarr conversion also works in a very similar way: