-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows disclaimer and change int to Integer. #26
Add windows disclaimer and change int to Integer. #26
Conversation
@lupemba Thank you very much for the PR ! I took advantage of this to adapt the types for some other functions. This is actually legacy code from Cfgrib.jl that I didn't really double check. Are you using GRIBDatasets.jl with GRIB.jl v4.0.0 ? Because I saw they added some support for windows, so this should be reflected here |
Hi @tcarion, I use the new version and I can see that they have added some windows support. The package tests still fails on windows because GRIB.Index is not defined for windows systems. Yesterday I discovered that my issues is not with windows but instead that the .grib file has two longitude and two latitude dimensions. Two different grids in one file. I tried to remove the length check from I am planning to make a new issue on this but I am just downloading a small file to reproduce it. |
Mhm, I see. It should actually be possible to do without
Unfortunaltely, I think it's a untrivial issue to solve. I see 2 workarounds:
Anyway, that'd be great if you can open an issue with a MWE :-) |
Thank you for making the package @tcarion. It is nice that we now can work with grib files in Julia.
My download from ECMWF is still queued. I hope to create the issue on Monday. |
I have tried to fix the issue I encountered with Int32, see issue #25
This does still not work completely since I am using Windows. I have therefore added a notice to the readme about the Windows support. It is easy to miss this when it is only written on GRIB.jl