Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with eccodes_jll v2.36 #36

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/variables.jl
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,7 @@

for d in dims
if !_is_length_consistent(d, dsdims)
@warn "The length of dimension $(dimname(d)) in variable $key is different
from the corresponding dimension in the dataset. This could lead to unexpected
behaviour."
@warn "The length of dimension $(dimname(d)) in variable $key is different from the corresponding dimension in the dataset. This could lead to unexpected behaviour."
end
end

Expand All @@ -171,7 +169,7 @@

Variable(ds, key, _filter_horizontal_dims(ds.dims), values, coordinate_attributes(key))
else
error("The key `$key` was been found in the dataset. Available keys: $(keys(ds))")
error("The key `$key` was not found in the dataset. Available keys: $(keys(ds))")

Check warning on line 172 in src/variables.jl

View check run for this annotation

Codecov / codecov/patch

src/variables.jl#L172

Added line #L172 was not covered by tests
end
end

Expand Down
6 changes: 3 additions & 3 deletions test/dataset.jl
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ using GRIBDatasets: CDM
u = ds2["u"]
@test u[:,:, 1, 1] isa AbstractArray{<:Any, 2}
@test_throws BoundsError u[:,:,1,2]
u10 = ds2["u10"]
u10 = ds2["avg_10u"]
@test GDS._dim_values(GDS._get_dim(u10, "heightAboveGround_2")) == [10]
t2m = ds2["t2m"]
t2m = ds2["mean2t"]
@test GDS._dim_values(GDS._get_dim(t2m, "heightAboveGround")) == [2]
end

Expand Down Expand Up @@ -187,7 +187,7 @@ using GRIBDatasets: CDM
end
end

@testset "test all files" begin
@testset "open all files" begin
for testfile in test_files
println("Testing: ", testfile)
index = FileIndex(testfile)
Expand Down
4 changes: 2 additions & 2 deletions test/dimensions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ using Test

@test keys(vertdims) == ["hybrid", "heightAboveGround", "heightAboveGround_2"]

u10 = filter_messages(index, cfVarName = "u10")
u10 = filter_messages(index, cfVarName = "avg_10u")
indices = messages_indices(u10, _alldims(u10))

@test indices[1] == [1, 1]
end
end
end
Loading