Test isgeometry on type of geometry. #179
Open
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be amazing but I have a vague memory that for some types it was not known? Or is that no longer true after I fixed ArchGDAL... What about WellKnownGeometry.jl ? |
|
I already fixed Wellknowngeometry. Might need a fix for Mixed() use cases, but I'll fix it when I need it. |
|
Ah sorry I was confused with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface actually tells you to do so, but it's easy to forget/skip. Found this for
isgeometry(GFT.WellKnownBinary)(blessed piracy in WellKnownGeometry) when working on GeoArrow purely based on the types of a column (not the first instance or similar).