Skip to content

Commit

Permalink
Avoid unneeded renormalizations of the quaternion (#118)
Browse files Browse the repository at this point in the history
* Don't normalize the rotated vector in ∇rotate
* Don't renormalize in conj or negation
  • Loading branch information
bjack205 authored May 26, 2020
1 parent 17815ad commit 8bf4a8c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/unitquaternion.jl
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ Base.rand(::Type{UnitQuaternion}) = Base.rand(UnitQuaternion{Float64})
# ~~~~~~~~~~~~~~~ Math Operations ~~~~~~~~~~~~~~~ #

# Inverses
conj(q::Q) where Q <: UnitQuaternion = Q(q.w, -q.x, -q.y, -q.z)
conj(q::Q) where Q <: UnitQuaternion = Q(q.w, -q.x, -q.y, -q.z, false)
inv(q::UnitQuaternion) = conj(q)
(-)(q::Q) where Q <: UnitQuaternion = Q(-q.w, -q.x, -q.y, -q.z)
(-)(q::Q) where Q <: UnitQuaternion = Q(-q.w, -q.x, -q.y, -q.z, false)

# Norms
LinearAlgebra.norm(q::UnitQuaternion) = sqrt(q.w^2 + q.x^2 + q.y^2 + q.z^2)
Expand Down Expand Up @@ -486,7 +486,7 @@ Jacobian of `R*r` with respect to the rotation
"""
function ∇rotate(q::UnitQuaternion, r::AbstractVector)
check_length(r, 3)
rhat = UnitQuaternion(zero(eltype(r)), r[1], r[2], r[3])
rhat = UnitQuaternion(zero(eltype(r)), r[1], r[2], r[3], false)
R = rmult(q)
2vmat()*rmult(q)'rmult(rhat)
end
Expand Down
2 changes: 1 addition & 1 deletion test/unitquat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import Rotations: vmat, rmult, lmult, hmat, tmat
@test UnitQuaternion(q) isa UnitQuaternion{Float64}
@test UnitQuaternion(q32) isa UnitQuaternion{Float32}

r = normalize(@SVector rand(3))
r = @SVector rand(3)
r32 = SVector{3,Float32}(r)
@test pure_quaternion(r) isa UnitQuaternion{Float64}
@test pure_quaternion(r32) isa UnitQuaternion{Float32}
Expand Down

0 comments on commit 8bf4a8c

Please sign in to comment.