Add documentation for RotationGenerator
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 15 15
Lines 1601 1601
=======================================
Hits 1411 1411
Misses 190 190
Continue to review full report at Codecov.
|
hyrodium
commented
Jan 15, 2022
| # create the null rotation (identity matrix) | ||
| # create the identity rotation (identity matrix) |
There was a problem hiding this comment.
I'm not familiar with these wordings, but the word "null rotation" seems different from "identity rotation".
Comment on lines
-36
to
+38
| x_{\mathrm{R}} &= x_{\mathrm{U}}/w_{\mathrm{U}} \\ | ||
| y_{\mathrm{R}} &= y_{\mathrm{U}}/w_{\mathrm{U}} \\ | ||
| z_{\mathrm{R}} &= z_{\mathrm{U}}/w_{\mathrm{U}} | ||
| x_{\mathrm{R}} &= x_{\mathrm{Q}}/w_{\mathrm{Q}} \\ | ||
| y_{\mathrm{R}} &= y_{\mathrm{Q}}/w_{\mathrm{Q}} \\ | ||
| z_{\mathrm{R}} &= z_{\mathrm{Q}}/w_{\mathrm{Q}} |
There was a problem hiding this comment.
These changes are related with #201. (UnitQuaternion -> QuatRotation)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.