Use GenericGraph for testing biconnectivity algorithms #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonschoelly
force-pushed
the
test-biconnectivity-with-generic-graph
branch
from
cd9fadd to
caeb9e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 97.17% 97.19% +0.01%
==========================================
Files 114 114
Lines 6656 6658 +2
==========================================
+ Hits 6468 6471 +3
+ Misses 188 187 -1 |
simonschoelly
force-pushed
the
test-biconnectivity-with-generic-graph
branch
from
caeb9e5 to
85e97f1
Compare
This was referenced Jul 2, 2023
|
@etiennedeg interesting insight here |
gdalle
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Good eye! This looks fine to me so I'm merging, but @simonschoelly maybe we should put a progress tracker in issue #224 so that we know where generic graphs are used in testing already?
Right, I will do that after my next PR |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the biconnectivity algorithms so that they test with
GenericGraphinstead ofSimpleGraph.With this, I discovered an error, where we incorrectly assumed that the result of
outneighbors(g, v)is indexable. To work around this without , I added a functioncollect_if_not_vectorthat converts the result ofoutneighborsto a vector unless it is already one. In the future we might think, if we either should adjust these algorithms, or instead require the neighbor functions to always return an indexable collection.