-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helpers.jl with initial value for Ref{Cuint} #1138
Conversation
This is supposed to be a C99 https://docs.hdfgroup.org/hdf5/develop/group___h5.html#ga70bfde4acd009cdd7bcd2f54c594e28a |
I think we also want to change to Cuchar here: Line 30 in 91ef284
|
Yeah, I didn't realize/forgot that a lot of the api files are generated. I guess the generator doesn't provide an initial value when generating so it relies on having the type size correct. Maybe best to change it to |
Once you change api_defs.jl, just run the gen_wrappers.jl script as indicated below. If you cannot, I would be happy to do it. Line 2 in 91ef284
|
Maybe we should switch to Clang.jl-generated wrappers. |
I worked on that a few years ago in LibHDF5.jl: In particular, this line: And this line would have lead to the correct definition: The problem is that we also have these custom error messages as well. |
I'm going to try to push this through soon |
* Update helpers.jl with initial value for Ref{Cuint} Fixes #1137 * Switch to using Cuchar --------- Co-authored-by: Mark Kittisopikul <[email protected]> Co-authored-by: Mark Kittisopikul <[email protected]>
Fixes #1137