Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable h5a_iterate and h5l_iterate assertion tests #1155

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented Jun 2, 2024

Disable assertion tests for h5a_iterate and h5l_iterate while we investigate why these tests are being inconsistent.

Also perhaps @assert is not the best way to test if an error is being thrown.

@mkitti mkitti requested a review from simonbyrne June 2, 2024 21:09
@mkitti
Copy link
Member Author

mkitti commented Jun 2, 2024

h5a_iterate: Test Failed at /home/runner/work/hdf5/hdf5/test/api.jl:41
  Expression: HDF5.API.h5a_iterate(f, HDF5.API.H5_INDEX_NAME, HDF5.API.H5_ITER_INC) do loc, name, info
    #= /home/runner/work/hdf5/hdf5/test/api.jl:44 =# @assert false
end
    Expected: AssertionError
  No exception thrown
Stacktrace:
 [1] macro expansion
   @ ~/work/hdf5/hdf5/test/api.jl:41 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [3] top-level scope
   @ ~/work/hdf5/hdf5/test/api.jl:4
h5l_iterate: Test Failed at /home/runner/work/hdf5/hdf5/test/api.jl:93
  Expression: HDF5.API.h5l_iterate(f, HDF5.API.H5_INDEX_NAME, HDF5.API.H5_ITER_INC) do loc, name, info
    return -1
end
    Expected: HDF5.API.H5Error
  No exception thrown
Stacktrace:
 [1] macro expansion
   @ ~/work/hdf5/hdf5/test/api.jl:93 [inlined]
 [2] macro expansion
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
 [3] top-level scope
   @ ~/work/hdf5/hdf5/test/api.jl:56

@mkitti mkitti merged commit fb52906 into JuliaIO:master Jun 2, 2024
20 checks passed
mkitti added a commit to mkitti/HDF5.jl that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant