Refactor files to remove small files and simplify file names #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dpsanders
commented
Apr 2, 2016
dpsanders
commented
- Simplify file names
- Moved macros from rounding.jl into macros.jl, and the non-macro stuff from rounding.jl into precision.jl
- Removed rationalize.jl that is no longer used
- Move short printing stuff into intervals.jl
| include("conversion_promotion.jl") | ||
| include("special.jl") | ||
| include("macros.jl") | ||
| include("conversion.jl") | ||
| include("arithmetic.jl") | ||
| include("precision.jl") |
There was a problem hiding this comment.
The file "precision.jl" contains, among others, the IntervalParameters type and other rounding functions. Though it seems to create no problems for the tests, for sanity I think it is better to include this file before any actual use of parameters or rounding stuff. In particular, include it before "arithmetic.jl".
|
I think I can merge it once my sole comment is implemented. |
|
It may be worth to implement the idea in #93 before merging this. |
dpsanders
force-pushed
the
refactor_files
branch
from
88692eb to
9bf2e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.