-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent downgrading on old version in mirror #889
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would also disable the ability to switch from a prerelease channel to the release channel, where we want a downgrade to happen. So I don't think we can merge this as is...
I completely missed that possibility, sorry. I have ready an incomplete patch for it, but there is another issue. What should be the default behaviour when the self update is run non interactlively. Should we default to not downgrade at all? Or install whatever it is found on the channel? I'd be more towards ignoring any downgrades, to avoid surprises. for now an example of interaction is the following:
Other possible behaviour to consider: if the version is the same, just update normally. EDIT: I'll push the changes made, with the caveat that they are still incomplete and need the non-interactive scenario to be addressed. |
I just opted for pushing a complete working version, so that if you agree it's ready. Namely:
|
f5f37f4
to
c62d3e0
Compare
c62d3e0
to
cfc4214
Compare
cfc4214
to
9bbaf96
Compare
…ror is lower than the current one.
…hing back from a preview version to the release version.
fix: reinstalling same version is not counted as downgrading.
should fix #250