Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vararg warnings #123

Closed
wants to merge 1 commit into from
Closed

Fix Vararg warnings #123

wants to merge 1 commit into from

Conversation

cscherrer
Copy link
Collaborator

In Julia 1.10 beta (at least) we get this warning a lot:

│  WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│  You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.

Here Simeon Schaub suggests that to address this, "Just use Vararg{Number} instead of Vararg{<:Number}". This PR makes this small change

@cscherrer cscherrer requested a review from oschulz August 4, 2023 22:25
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Package name latest stable
MeasureTheory.jl

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (609a2bd) 55.55% compared to head (d745078) 55.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           mt-015     #123   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files          42       42           
  Lines        1179     1179           
=======================================
  Hits          655      655           
  Misses        524      524           
Files Changed Coverage Δ
src/combinators/smart-constructors.jl 24.69% <ø> (ø)
src/combinators/power.jl 82.25% <100.00%> (ø)
src/static.jl 80.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz
Copy link
Collaborator

oschulz commented Aug 4, 2023

I have this in #122 already, I think - if it's ok I'd hold off until that done (hopefully very soon) to reduce merge conflicts.

@cscherrer
Copy link
Collaborator Author

I don't think so, the pr targets that branch

@cscherrer
Copy link
Collaborator Author

OTOH no problem waiting if you prefer, it's pretty minor I think

@oschulz
Copy link
Collaborator

oschulz commented Aug 5, 2023

Thanks - I'll get back to that monster-PR, promise!

@oschulz
Copy link
Collaborator

oschulz commented Sep 9, 2024

Included in #142

@oschulz oschulz closed this Sep 9, 2024
@oschulz oschulz deleted the cs-vararg branch September 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants