Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fenv_t initializer #308

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Fix fenv_t initializer #308

merged 1 commit into from
Nov 9, 2024

Conversation

000lbh
Copy link
Contributor

@000lbh 000lbh commented Oct 10, 2024

I have no idea why previous versions compile on GitHub actions, but they don't on my loongarch64 machine, and there was also someone reported on aarch64 architecture #278 . Initializer of a struct should be a brace-enclosed list. Btw, my gcc version is 14.2.1, it seems that cross-compile gcc version in GitHub actions is old.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.03%. Comparing base (c1e8462) to head (6404565).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   39.02%   39.03%           
=======================================
  Files         233      233           
  Lines        6144     6151    +7     
  Branches     1608     1608           
=======================================
+ Hits         2398     2401    +3     
- Misses       3393     3397    +4     
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

000lbh added a commit to 000lbh/loongarch-packages that referenced this pull request Oct 10, 2024
wszqkzqk added a commit to lcpu-club/loongarch-packages that referenced this pull request Oct 10, 2024
See also [openlibm#308](JuliaMath/openlibm#308)

Co-Authored-By: Zhou Qiankang <[email protected]>
@yuyichao
Copy link
Contributor

yuyichao commented Oct 10, 2024

It seems that the definition of fenv_t in this repo is not a struct except on x86 (both 32 and 64bit). However, the system one does seem to be a struct. Which one is intended to be used?

(The include guard is such that if one version of fenv is included, the other one won't, at least on Linux)

@000lbh
Copy link
Contributor Author

000lbh commented Oct 10, 2024

Thanks for you comment. I didn't notice there are some openlibm_fenv_ARCH.h in the repo before. It is strange that fenv.c of some architectures like arm, amd64 and aarch64 includes openlibm_fenv.h, which uses project's fenv.h, but others like loongarch64 and riscv64 directly includes system's fenv.h

Maybe I should update my PR, to change these two architectures to use openlibm_fenv.h or just revert my changes to other architectures? or should I fix this inconsistence issue?

@000lbh
Copy link
Contributor Author

000lbh commented Nov 5, 2024

Maybe this version is ok

@ViralBShah ViralBShah merged commit c4667ca into JuliaMath:master Nov 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants