-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce preference for automatic ascii visualization of system #122
Conversation
de598e3
to
db0e442
Compare
I personally haven't made much use of it, and have occasionally found it distracting, but can also imagine cases where it would be useful as you say. I would be fine with either option you describe. |
I don't view systems enough in the REPL to have strong opinions on this. |
db0e442
to
4d4ecdc
Compare
I'm ok with either option. If we go with a settable default then I will obviously vote to have a slim display as the default. |
Ok, I added the preferences. By default |
If one of you gives your ok, I guess we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, should for sure fix the one tiny typo, and if people want to discuss the minor potential ambiguity, we can, but I'm also okay just merging this as-is since it's not a huge deal
Is this basically good to go? I don't think it should clash with #130 AFAICT, so presumably once coverage issues are addressed, it can be merged? I might have some time to add those couple of tests this afternoon if you don't already have them locally or something... |
No go ahead ! |
aa4980e
to
987df6e
Compare
Follow-up to #121 to discuss ascii visualisation preferences. Ping @cortner @rkurchin @jgreener64 to get some opinions.
I personally find it quite convenient to automatically get this insight when working in the REPL or a notebook, but this may just be me. I also found it helps students ... but again I introduced it, so I'm biased.
Options in my opinion are:
visualize_ascii
manually each time. Pros: Clear what happens, least complexity; Cons: It's an extra function to learn for something where Julia has builtin mechanics.In fact there may even be some builtin show preferences in Julia one can use for the second point ... I vaguely remember that, but I have not checked.
Other thoughts ?