Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1026: Allow GPU arrays in FFTGrid #1029

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

Technici4n
Copy link
Contributor

#996 accidentally changed the type of G_vectors from an AbstractArray generic to Array. However, we need G_vectors to be a GPU array when running on a GPU. This PR reintroduces the generic for the array types, now in FFTGrid.

Fixes #1026.

@mfherbst mfherbst enabled auto-merge (squash) November 28, 2024 21:00
@mfherbst mfherbst merged commit 6cb2c19 into JuliaMolSim:master Nov 28, 2024
7 of 8 checks passed
@Technici4n Technici4n deleted the fix-1026 branch November 29, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DFTK broken on GPUs
2 participants