-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YAJL recipe #813
Add YAJL recipe #813
Conversation
Is this supposed to work on Windows at all? |
ah yes it should, i need to look at this evidently. |
Yes, I'm reading the same file, but I don't think that helps, it's about using Visual Studio |
I think it's creating broken Makefiles, |
Oh well... I'm just gonna remove Windows then. |
I have the feeling that we can patch the CMake file to just remove entire W32 branch, it's just wrong (more precisely, it assumes that Visual Studio is the only compiler for Windows) |
And we also already have the patch: https://github.com/msys2/MINGW-packages/blob/2cfdf054df2c826d7c61237ee5ac2453b0f3964d/mingw-w64-yajl/01-fix-compiler.patch |
oh cool! |
It works locally now, so all the builds should succeed. |
I opened a PR upstream to fix the CMake file: lloyd/yajl#228 |
It's very unlikely to be merged i think, development has long since stopped on that repo 😬 |
Oh, I didn't even check the activity 🤦 |
for use in YAJL.jl