Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenSpiel] Version Bump #8706

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[OpenSpiel] Version Bump #8706

merged 2 commits into from
Jun 19, 2024

Conversation

findmyway
Copy link
Contributor

No description provided.

@giordano
Copy link
Member

This could now use abseil_cpp_jll and the other packages @eschnett built last week.

@fingolfin
Copy link
Member

@findmyway are you interested in updating it as indicated by @giordano ? Or should we just merge it for now?

@findmyway
Copy link
Contributor Author

findmyway commented Jun 8, 2024

I was waiting for the merge of google-deepmind/open_spiel#1230
Now that v1.5 got released, I'll update it together.


It seems I need to update the upstream CMakeLists.txt file to reuse abseil_cpp_jll. To make this package easier to maintain, I prefer keeping it as it is now.

@ViralBShah
Copy link
Member

Should we merge this?

@fingolfin fingolfin merged commit 8af3fcf into JuliaPackaging:master Jun 19, 2024
16 checks passed
amontoison pushed a commit that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants