Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat bounds for more packages #789

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add compat bounds for more packages #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,20 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
Sockets = "6462fe0b-24de-5631-8697-dd941f90decc"

[compat]
Distributed = "1"
AMDGPU = "0.5.7, 0.6"
CUDA = "3, 4, 5"
DocStringExtensions = "0.8, 0.9"
Libdl = "1"
MPICH_jll = "4"
MPIPreferences = "0.1.8"
MPItrampoline_jll = "5"
OpenMPI_jll = "4"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we have version 5 as well, but at the moment there's something very broken, so it doesn't work:

julia> Base.BinaryPlatforms.HostPlatform()
Linux x86_64 {cxxstring_abi=cxx11, julia_version=1.9.3, libc=glibc, libgfortran_version=5.0.0, libstdcxx_version=3.4.30}

julia> OpenMPI_jll.is_available()
false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using the OpenMPI binary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using MPI, I just installed the OpenMPI_jll package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only load OpenMPI_jll if the appropriate preferences are set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but this was failing in #788 to import OpenMPI_jll v5, no problem with v4. I honestly don't have the time to track that one down.

PkgVersion = "0.3"
PrecompileTools = "1.0.1"
Requires = "~0.5, 1.0"
Serialization = "1"
Sockets = "1"
julia = "1.6"

[extensions]
Expand Down