Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Switch to using the cell method #224

Closed
wants to merge 19 commits into from
Closed

Switch to using the cell method #224

wants to merge 19 commits into from

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 added documentation WIP Work in progress, do not merge... labels Mar 5, 2020
@SimonDanisch
Copy link
Member

The second url is 404 ;)

@asinghvi17 asinghvi17 closed this Mar 5, 2020
@asinghvi17 asinghvi17 reopened this Mar 5, 2020
@asinghvi17
Copy link
Member Author

Oh...my bad, the doc build doesn't run on PRs not targeting master

@asinghvi17 asinghvi17 changed the base branch from as/betterembedding to master March 5, 2020 13:47
@asinghvi17 asinghvi17 closed this Mar 5, 2020
@asinghvi17 asinghvi17 reopened this Mar 5, 2020
@piever
Copy link
Member

piever commented Mar 6, 2020

Concerning the StatsMakie doc, now I think the situation is a bit unclear, as there is an "untested" version here, as well as a tested version here. Should we just remove the doc page from StatsMakie in favor of unified documentation?

@SimonDanisch
Copy link
Member

I'm for: http://makie.juliaplots.org/previews/PR223/statsmakie.html

Concerning the StatsMakie doc, now I think the situation is a bit unclear, as there is an "untested" version here, as well as a tested version here. Should we just remove the doc page from StatsMakie in favor of unified documentation?

https://github.com/JuliaPlots/AbstractPlotting.jl/issues/349
I want to move docs to the packages that are responsible for it and test them there...And then just collect them here to also have a central place for makieverse!

@jkrumbiegel
Copy link
Member

jkrumbiegel commented Mar 6, 2020

also 223, the other one cuts off a lot of code for me

@piever
Copy link
Member

piever commented Mar 6, 2020

I want to move docs to the packages that are responsible for it and test them there...And then just collect them here to also have a central place for makieverse!

I see, so the way forward is JuliaPlots/StatsMakie.jl#100.

Concerning the two options, I find 223 much nicer.

@asinghvi17
Copy link
Member Author

Sounds good - this was just a small alternative I wanted to explore to shorten the page size, but I agree that it doesn't show long code well. I've already merged #223, so will just close this.

@asinghvi17 asinghvi17 closed this Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation WIP Work in progress, do not merge...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants