Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing user flags to kaleido executable #21

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

bbejanov
Copy link
Contributor

@bbejanov bbejanov commented Sep 9, 2024

This PR fixes passing user arguments to start.

For example, the following currently fails to correctly pass the desired offline path to plotlyjs to the kaleido executable. It is fixed by this PR.

PlotlyKaleido.start(plotlyjs="/path/to/plotly-latest.min.js") 

@BeastyBlacksmith BeastyBlacksmith merged commit f5c5e79 into JuliaPlots:main Sep 10, 2024
4 of 6 checks passed
@jd-foster jd-foster mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants