Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for plotlyjs backend, for IJulia #1877

Closed
wants to merge 2 commits into from

Conversation

lwabeke
Copy link
Contributor

@lwabeke lwabeke commented Jan 2, 2019

Tries to address #1793 and JuliaPlots/PlotlyJS.jl#221

IJulia and REPL plotting seems to work again, however from REPL plot! creates a new empty window in addition to updating existing window (this behaviour seems to be similar to master), but only if run on a separate line, running plot(rand(10));plot!(rand(5)) doesn't create the extra window

… creates a new empty window in addition to updating existing window, but only if run on a seperate line, running plot(rand(10));plot!(rand(5)) doesn't create the extra window
@mkborregaard
Copy link
Member

There are some conflicts - could you rebase your pr on current master?

@mkborregaard mkborregaard requested a review from daschw January 2, 2019 10:23
@mkborregaard
Copy link
Member

Thanks. It looks sensible - what's "partial" about the fix?

@lwabeke
Copy link
Contributor Author

lwabeke commented Jan 2, 2019

Sorry, weird, if I checkout master, I wasn't getting the modification to _create_backend, but manually removed that part of the change.

I'm still a little bit worried that the conditional write I removed is still required for certain scenarios, but I don't know where and it doesn't work in its old form.

@lwabeke
Copy link
Contributor Author

lwabeke commented Jan 3, 2019

"Partial" in terms of cutting away branches, which I can only assume had been required in certain scenarios.
Maybe it should then be only partially tested: From REPL, from localhost using IJulia notebook() and later minimally from Juno.
My guess is the use_remote part that I removed was for JuliaBox or some other setup of using IJulia remotely. Also is there other IDEs where plotting has been integrated, maybe it was for one of them?

Initially I added the partial also due to the fact of a blank plot window still showing up when calling plot!, however it seems that is a seperate bug also in the mainline.

@mkborregaard mkborregaard mentioned this pull request Jan 9, 2019
@mkborregaard
Copy link
Member

superseded by #1885 . But thanks @lwabeke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants