Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset array hist #4860

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Fix offset array hist #4860

merged 2 commits into from
Jan 8, 2024

Conversation

isentropic
Copy link
Member

@isentropic isentropic commented Jan 4, 2024

Description

Fixing this probably wouldn't work with like star wars arrays or some weird thing but at least it should work with linear arrays

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@isentropic isentropic changed the title Master Fix offset array hist [bug](https://github.com/JuliaPlots/Plots.jl/issues/4855) Jan 4, 2024
@isentropic isentropic changed the title Fix offset array hist [bug](https://github.com/JuliaPlots/Plots.jl/issues/4855) Fix offset array hist Jan 4, 2024
@isentropic
Copy link
Member Author

@t-bltg @BeastyBlacksmith this is probably safe to merge, but I've been so disconnected from Plots for a while, maybe something changed in the workflow

@isentropic
Copy link
Member Author

probably don't squash as I tried to fix python tests here too

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7cd27c4) 90.29% compared to head (0215f71) 90.28%.
Report is 25 commits behind head on master.

Files Patch % Lines
src/backends.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4860      +/-   ##
==========================================
- Coverage   90.29%   90.28%   -0.02%     
==========================================
  Files          40       40              
  Lines        8752     8763      +11     
==========================================
+ Hits         7903     7912       +9     
- Misses        849      851       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isentropic
Copy link
Member Author

isentropic commented Jan 4, 2024

well pythonplot doesn't bug out now, but something else is wrong i'm not sure what. I need help with deciphering the errors for ubuntu 1.10, otherwise it is some windows plotlykaleido thing which I have no idea bout

@isentropic isentropic merged commit 0d95673 into JuliaPlots:master Jan 8, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant