fix gtk hang, update refs

src/gui.jl

@@ -30,8 +30,14 @@ function replace_refimg_dialog(tmpfn, reffn_old; reffn_new = reffn_old)
     Gtk.showall(win)
 
     # now ask the question
-    if Gtk.ask_dialog("Should we make this the new reference image?", "No", "Yes")
-        replace_refimg(tmpfn, reffn_new)
+    t = @async begin
+        state = Gtk.ask_dialog("Should we make this the new reference image?", "No", "Yes")
+        if state
+            replace_refimg(tmpfn, reffn_new)
+        end
+    end
+    if !isinteractive()
+        wait(t)
     end
 
     Gtk.destroy(win)

src/macros.jl

@@ -1,12 +1,12 @@
-macro visualtest(testfun, refname, popup=true, tol=0.02)
+macro visualtest(testfun, refname, popup=true, tol=1e-3)
   esc(quote
     testFilename = tempname()*".png"
     $testfun(testFilename)
     @test test_images(testFilename, $refname, popup=$popup, tol=$tol) |> success
   end)
 end
 
-macro plottest(plotfun, refname, popup=true, tol=0.02)
+macro plottest(plotfun, refname, popup=true, tol=1e-3)
   esc(quote
     testFilename = tempname()*".png"
     if $plotfun isa Function

src/utils.jl

@@ -21,7 +21,7 @@ function blurdiff(A::AbstractArray, B::AbstractArray, sigma)
     Af = imfilter(A, kern, NA())
     Bf = imfilter(B, kern, NA())
     d = sad(Af, Bf)
-    diffscale = max(_abs(maxabsfinite(A)), _abs(maxabsfinite(B)))
+    diffscale = max(_abs(maximum_finite(abs, A)), _abs(maximum_finite(abs, B)))
     diffpct = d / (length(Af) * diffscale)
 
     diffpct