-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Add transmission-line model #190
base: master
Are you sure you want to change the base?
Conversation
Seems to me that
That's bad, that reminds me this issue but i thought it was solved. Do you have an indication where such values arise? |
Here are results with First time step including the (continuous-time) initial states: Observations:
|
Updated projections of This is definitely a major improvement but still an order of magnitude away from the true solution. |
With the latest fixes, and ignoring a current bug in the discretization for now, the results of
|
Another bugfix later, we are getting closer... As can be seen, Here is the same plot for a 10x smaller time step: |
This is based on the paper mentioned in the file and the CORA model and settings.
Problems:
Taylor order not high enough
when using order 6 (but works with order 8 already)clarification needed
mid(B)
(paper) or fromB
(CORA implementation)-A⁻¹
(paper) or with+A⁻¹
(CORA implementation)initial states are not contained in the flowpipe
we found the reason: the implemented algorithm is only sound if the origin is contained in the inputs. so we need the sound version first
(likely a consequence:) projection of first set (discretized X0) to
U_out
(dimensionη
) already spans interval [-3, 3]*10^4 (paper: [-0.201, 0.201])the set X0 (called R(0) in the paper) is a zonotope centered in the origin with generator matrix
[C 0; 0 D]
whereC = diag(0.201)
andD = diag(1e-3)
both in JuliaReach and in CORAso there seems to be a problem in the discretization
(likely a consequence:) computed zonotope centers contain
NaN
s andInf
s (most probably just a consequence of the big numbers mentioned above)dimensional errors in projection
further suggestions by @mforets
inv(mid(x))
tomid(inv(x))