New version: Turing v0.30.9 #105315
Merged
New version: Turing v0.30.9 #105315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Apr 21, 2024
JuliaRegistrator
commented
- Registering package: Turing
- Repository: https://github.com/TuringLang/Turing.jl
- Created by: @torfjelde
- Version: v0.30.9
- Commit: a022dc6b5990199187018e64501b3da0d7d0bb29
- Reviewed by: @torfjelde
- Reference: TuringLang/Turing.jl@a022dc6#commitcomment-141194868
- Description: Bayesian inference with probabilistic programming.
- Release notes:
UUID: fce5fe82-541a-59a6-adf8-730c64b5f9a0 Repo: https://github.com/TuringLang/Turing.jl.git Tree: 4170ff68a0aa2b26b3944ba7bd8789a46d34e6bc Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator
referenced
this pull request
in TuringLang/Turing.jl
Apr 21, 2024
* initial work on the new gibbs sampler * added tests for the new Gibbs sampler * added tests for new Gibbs * new Gibbs is now sampling (correctly) sequentially * let's not overload merge just yet * export GibbsV2 + added more samplers to the tests * added TODO comment * removed lots of varinfo related merging functionality that is now available in DynamicPPL * shifting some code around * removed redundant constructor for GibbsV2 * added GibbsContext which is similar to FixContext but also computes the log-prob of the fixed variables * adopted the rerun mechanism in Gibbs for GibbsV2, thus fixing the issues with some of the tests for GibbsV2 * broken tests are no longer broken * fix issues with dot_tilde_* impls for GibbsContext * fix for dot_tilde_assume when using GibbsContext * fixed re-running of models for Gibbs sampling properly this time * added new gibbs to tests * added some further comments on why we need `GibbsContext` * went back to using `DynamicPPL.condition` rather than using custom `GibbsContext` while we wait for TuringLang/DynamicPPL.jl#563 to be merged * add concrete comment about reverting changes for `gibbs_condition` * Update test/mcmc/gibbs_new.jl Co-authored-by: Hong Ge <[email protected]> * fixed recursive definition of `condition` varinfos * use `fix` instead of `condition` * Revert "use `fix` instead of `condition`" This reverts commit f87e2d1. * rmeoved unnused symbol * Revert "went back to using `DynamicPPL.condition` rather than using custom" This reverts commit 53bd707. * bump compat entry of DynamicPPL so we can overload acclogp! * update assume for SMC samplers to make use of new `acclogp!` * added proper impl of acclogp!! for SMC samplers + made accessing task local varinfo and rng a bit nicer * added experimental module and moved gibbs to it * fixed now-inccorect references in new gibbs file * updated gibbs tests * moved experimental gibbs tests * updated tests to include experiemntal tests * removed refrences to previews tests of experimental Gibbs sampler * removed solved TODO * added a comment on `reconstruct_getvalue` usage * bump patch version * added comments on future work * Update test/experimental/gibbs.jl * fixed bug where particle samplers didn't properly account for weightings of logpdf, etc. * relax atol for a numerical test with Gibbs a bit * fixed bug with `AbstractDict` constructor for experimental `Gibbs` * aaaalways link the varinfo in the new Gibbs sampler, just to be sure * add test to cover recent improvement to `DynamicPPL.subset` ref: TuringLang/DynamicPPL.jl#587 * bump compat entry for DynamicPPL * added some docstrings * fixed test * fixed import * another attempt at fixing tests * another attempt at fixing tests * attempt at fix tests * forgot something in previos commit * cleaned up the experimental Gibbs sampler a bit * removed accidentaly psuedocode inclusion * Apply suggestions from code review * relaxed olerance in one MH test a bit * bump patch version --------- Co-authored-by: Hong Ge <[email protected]>
JuliaRegistrator
temporarily deployed
to
stopwatch
GitHub Actions
Inactive
JuliaRegistrator
temporarily deployed
to
stopwatch
GitHub Actions
Inactive
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.