Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: NeighbourLists v0.5.4 #69894

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 2fcf5ba9-9ed4-57cf-b73f-ff513e316b9c
Repo: https://github.com/JuliaMolSim/NeighbourLists.jl.git
Tree: 8bbbd65d6cefdc7338282220f8d1620f65c2855e

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
@github-actions
Copy link
Contributor

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Does not meet sequential version number guideline: version 0.5.4 skips over 0.5.1
  • The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: StaticArrays

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@cortner
Copy link
Contributor

cortner commented Oct 11, 2022

  • This PR is to move the NeighbourList.jl registration from a "persona" registry to the General registry, hence the gaps in the version numbers.
  • Regarding the upper version bound on StaticArrays: these are used only in a very elementary way and compatibility was never broken. But I can put a bound for the next version I register.

I would be grateful if this PR can be merged.

@cortner
Copy link
Contributor

cortner commented Oct 25, 2022

@vchuravy and @dallasfoster -- I'm sorry to ping you here. But I think this was an important step to getting everybody to start coordinating on the neighbourlist interface as we discussed. Are you able to get this merged?

@vchuravy
Copy link
Member

Can you declare the StaticArrays compat and just retrigger registratior on the same version?

Compat bounds being declared is a hard requirement

@cortner
Copy link
Contributor

cortner commented Oct 25, 2022

see #71009

@vchuravy vchuravy closed this Oct 25, 2022
@DilumAluthge DilumAluthge deleted the registrator/neighbourlists/2fcf5ba9/v0.5.4 branch November 13, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants