-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: FMin v1.0.0 #99531
New package: FMin v1.0.0 #99531
Conversation
JuliaRegistrator
commented
Jan 25, 2024
- Registering package: FMin
- Repository: https://github.com/kagalenko-m-b/FMin.jl
- Created by: @kagalenko-m-b
- Version: v1.0.0
- Commit: 91a913f3228e0b97d7ddd77e66cf6ac9e70ec97f
- Reviewed by: @kagalenko-m-b
- Reference: Trigger Julia Registrator kagalenko-m-b/Fminbnd.jl#2
UUID: b7bab496-830c-4b53-8aec-8b9a988c40b4 Repo: https://github.com/kagalenko-m-b/FMin.jl.git Tree: a4050c0a5d00c46e86558c960cd6c0c656d58719 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
I believe FMin is a good name for this package, because it is as literal as possible translation to Julia of a popular and well-known Fortran routine http://www.netlib.org/fmm/fmin.f |
This actually seems okay to me, but you'll have to wait three days and then ping the slack for a manual merge [noblock] |
[noblock] @kagalenko-m-b Can you try retriggering this registration (just add another In theory, it should then merge automatically because I applied the "name similarity is okay" tag. Otherwise, we'll have to ping a registry maintainer for a manual merge. But I'm kinda curious if retriggering works. |
Oh, never mind, there's also "Name is not at least 5 characters long", which I can't override [noblock] |
Does "fmin" always mean this same algorithm in practice? For example, in Anyway, I would suggest something like "NetlibFMin" or "FMinNetlib" to avoid potential ambiguities. |
I would also prefer a longer and more descriptive name. |
Netlib's |
I tend to agree with the others here that a more descriptive name would be preferable. As far as I can see, "fmin" isn't a (well known) package or library name in any of the mentioned languages but only a (sub-)functionality. On top of that, as pointed out by @aplavin, it can even mean different things. Therefore, I would not make an exception to our general rule here. |
Happy to register this package under a more descriptive name, though that will need a new PR. |
Follow-up in #119764 |