Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: FMin v1.0.0 #99531

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: b7bab496-830c-4b53-8aec-8b9a988c40b4
Repo: https://github.com/kagalenko-m-b/FMin.jl.git
Tree: a4050c0a5d00c46e86558c960cd6c0c656d58719

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name is not at least 5 characters long

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@kagalenko-m-b
Copy link

kagalenko-m-b commented Jan 25, 2024

I believe FMin is a good name for this package, because it is as literal as possible translation to Julia of a popular and well-known Fortran routine http://www.netlib.org/fmm/fmin.f
[noblock]

@goerz
Copy link
Member

goerz commented Jan 25, 2024

This actually seems okay to me, but you'll have to wait three days and then ping the slack for a manual merge

[noblock]

@goerz
Copy link
Member

goerz commented Jan 31, 2024

[noblock] @kagalenko-m-b Can you try retriggering this registration (just add another @JuliaRegistrator register comment to kagalenko-m-b/Fminbnd.jl#2).

In theory, it should then merge automatically because I applied the "name similarity is okay" tag. Otherwise, we'll have to ping a registry maintainer for a manual merge. But I'm kinda curious if retriggering works.

@goerz
Copy link
Member

goerz commented Jan 31, 2024

Oh, never mind, there's also "Name is not at least 5 characters long", which I can't override

[noblock]

@aplavin
Copy link
Contributor

aplavin commented Feb 6, 2024

Does "fmin" always mean this same algorithm in practice? For example, in scipy.optimize.fmin.
Btw, the first google result on "fmin" is C++ std::fmin that does a completely different thing.

Anyway, I would suggest something like "NetlibFMin" or "FMinNetlib" to avoid potential ambiguities.

@DilumAluthge
Copy link
Member

I would also prefer a longer and more descriptive name.

@kagalenko-m-b
Copy link

Does "fmin" always mean this same algorithm in practice? For example, in scipy.optimize.fmin. Btw, the first google result on "fmin" is C++ std::fmin that does a completely different thing.

Netlib's fmin is clearly the oldest of those. In addition, there already is an fmin repo on Github, that contans Fortran 90 port of the original Fortran 77 routine. It's that repository that put me in mind to publish the literal fmin port that I have written before.

@carstenbauer
Copy link
Member

I tend to agree with the others here that a more descriptive name would be preferable. As far as I can see, "fmin" isn't a (well known) package or library name in any of the mentioned languages but only a (sub-)functionality. On top of that, as pointed out by @aplavin, it can even mean different things. Therefore, I would not make an exception to our general rule here.

@LilithHafner
Copy link
Member

Happy to register this package under a more descriptive name, though that will need a new PR.

@giordano giordano deleted the registrator-fmin-b7bab496-v1.0.0-9e69011cc7 branch March 11, 2024 11:27
@goerz
Copy link
Member

goerz commented Nov 19, 2024

Follow-up in #119764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants