Remove some tests and split the backends and NLP/NLS into different CI jobs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 4 4
Lines 425 425
=======================================
Hits 389 389
Misses 36 36 Continue to review full report at Codecov.
|
abelsiqueira
force-pushed
the
lighter
branch
3 times, most recently
from
a43300a to
fa50193
Compare
|
|
|
|
|
|
abelsiqueira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed some specific tests:
view_subarray_nl{p,s}, tests that the function calls work with views of arrays;coord_memory_nlp, tests that the allocation of some in place functions are smaller than their allocation counter-parts.I split the NLPModelsTest tests into 6 parts. For each AD backend and for NLP and NLS. Now there are 18 tests for each Julia version. I removed the nightly version as well. Still takes a lot of time.
Finally, when called in breakage of other packages, I chose to test only ForwardDiff. I think this affects only NLPModels.jl, NLPModelsTest.jl and NLPModelsModifiers.jl.