Upgrade to ColPack v0.4 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I don't know what's wrong with the tests on Julia 1.10, especially since they pass on Julia 1.6. I really really hope I didn't break ColPack but given the light test suite I cannot completely exclude it |
|
And the docs failure is SymbolicUtils acting up again |
Not urgently, it was just the natural consequence of my ColPack refresh |
tmigot
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts to the breaking v0.4 of ColPack that I helped release. It supersedes #234
I had to fix SymbolicUtils to v1.5.1 in order for the tests to pass, see control-toolbox/CTDirect.jl#88 (comment)
@amontoison can you approve the workflows?