Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoreoptsum fails after change in JSON file structure in 4.25.0 #774

Closed
dmbates opened this issue Jun 27, 2024 · 2 comments · Fixed by #775
Closed

restoreoptsum fails after change in JSON file structure in 4.25.0 #774

dmbates opened this issue Jun 27, 2024 · 2 comments · Fixed by #775
Assignees

Comments

@dmbates
Copy link
Collaborator

dmbates commented Jun 27, 2024

One of the first checks in restoreoptsum is on the keys in the dictionary created from the JSON file. If the optsum JSON file was created with a version prior to 4.25 attempts to restore this optsum under 4.25.0 will fail, with a somewhat misleading error message. I will split the checks into two parts, one on the fields and one on the lower bounds and allow for patching pre-4.25 saved optsums to the 4.25 names.

@dmbates dmbates self-assigned this Jun 27, 2024
@palday
Copy link
Member

palday commented Jun 27, 2024

AH, I was wondering why I was having so many problems with previously working code when trying to render EmbraceUncertainty....

@dmbates
Copy link
Collaborator Author

dmbates commented Jun 27, 2024

I should have a PR ready shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants