More sophisticated checks in restoreoptsum.

[dmbates]

Closes #774

Did behavior change? Did you add need features? If so, please update NEWS.md

• add entry in NEWS.md
• after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

• I've bumped the version appropriately

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (34899cf) to head (a2b0857).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   96.93%   96.99%   +0.06%     
==========================================
  Files          34       34              
  Lines        3358     3360       +2     
==========================================
+ Hits         3255     3259       +4     
+ Misses        103      101       -2     

Flag	Coverage Δ
current	96.93% <100.00%> (+0.06%)	⬆️
minimum	96.84% <100.00%> (+<0.01%)	⬆️
nightly	96.50% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[palday]

@dmbates can you add a test with loading a 4.22 optsum? That would also serve as a potential test if we add even more fields (restoreoptsum! would break again and thus we would be reminded to update it).

[dmbates]

I added tests and improved coverage slightly.

[palday]

@dmbates I made a few changes directly:

• made sure that "optional" fields are actually loaded when they exist
• (fixed an old bug in how that was done for fitlog)
• issue a warning when loading an old fit

[dmbates]

Did I accidentally commit a lcov.info file? I use the "Run tests with coverage" option in VS code which creates a lcov.info file and I see you have added that name to .gitignore

[palday]

Did I accidentally commit a lcov.info file? I use the "Run tests with coverage" option in VS code which creates a lcov.info file and I see you have added that name to .gitignore

No, but I almost did 😂

[dmbates]

@JuliaRegistrator register

[JuliaRegistrator]

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.