Use TestEnv #89
Merged
Use TestEnv #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 96.24% 93.69% -2.56%
==========================================
Files 7 7
Lines 533 460 -73
==========================================
- Hits 513 431 -82
- Misses 20 29 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
# Conflicts: # src/TestReports.jl # src/runner.jl
oxinabox
reviewed
Oct 17, 2024
src/runner.jl
Outdated
| testfilepath = gettestfilepath(ctx, pkgspec) | ||
|
|
||
| ctx, pkgspec = try | ||
| TestEnv.ctx_and_pkgspec(pkg) |
There was a problem hiding this comment.
ideally we wouldn't use the TestEnv internals here.
Because we would like to contain all the evil of accessing interals of Pkg into TestEnv so TestReports can be safe from it
There was a problem hiding this comment.
but i don't think should block on this
There was a problem hiding this comment.
Added a TODO and will make an issue after merge
oxinabox
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just merged in main and this seems to be passing, picking up my work from over two years ago! Unfortunately I don't remember why this wasn't working before or why I wasn't happy with it, possibly because it failed for V1 (but then I dropped tests for V1). Would be grateful for @oxinabox and/or @omus to take a look at this 🙏
Hopefully will fix a few issues (e.g. #121 #122 )
edit: Just added back in V1 tests so will see what happens
edit 2: They fail, and they fail on master too (at least locally for me). At this point I think the best way forward is to remove 1.0 unless anyone has any objections?