Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mime-db update 1.53.0 #11

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Update mime-db update 1.53.0 #11

merged 5 commits into from
Nov 5, 2024

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Nov 5, 2024

Updated the db to 1.53.0

Used an OrderedDict implementation to match https://github.com/jshttp/mime-types (this was the original intention)

With the new db, there was one change: .mp4 went from video/mp4 to application/mp4... I'm not happy with that buy maybe it's not about what makes me happy?

This also happened in the js lib: jshttp/mime-types#119 (comment)

But reading the RFC that defines the mimes makes me believe that video/mp4 is in fact a better default, application/mp4 is not more general: it is only meant for mp4 files without video or audio content.

Copy link

github-actions bot commented Nov 5, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/JuliaWeb/MIMEs.jl", rev="update-1.53.0")
julia> using MIMEs

Or run this code in your browser: Run with binder

@fonsp fonsp marked this pull request as ready for review November 5, 2024 22:00
@fonsp fonsp merged commit c3ce1f5 into main Nov 5, 2024
@fonsp fonsp deleted the update-1.53.0 branch November 5, 2024 22:20
@fonsp fonsp linked an issue Nov 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0 release
1 participant